carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenerlu <...@git.apache.org>
Subject [GitHub] carbondata pull request #1112: [CARBONDATA-1244] Rewrite README.md of presto...
Date Thu, 29 Jun 2017 04:13:16 GMT
Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1112#discussion_r124708591
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
    @@ -72,25 +72,54 @@
      * 2:FileFactory, (physic table file)
      * 3:CarbonCommonFactory, (offer some )
      * 4:DictionaryFactory, (parse dictionary util)
    + *
    + * Currently, it is mainly used to parse metadata of tables under
    + * the configured carbondata-store path and filter the relevant
    + * input splits with given query predicates.
      */
     public class CarbonTableReader {
     
       private CarbonTableConfig config;
    +
    +  /**
    +   * The names of the tables under the schema (this.carbonFileList).
    +   */
       private List<SchemaTableName> tableList;
    +
    +  /**
    +   * carbonFileList represents the store path of the schema, which is configured as carbondata-store
    +   * in the CarbonData catalog file ($PRESTO_HOME$/etc/catalog/carbondata.properties).
    +   * Under the schema store path, there should be a directory named as the schema name.
    +   * And under each schema directory, there are directories named as the table names.
    +   * For example, the schema is named 'default' and there is two table named 'foo' and
'bar' in it, then the
    --- End diff --
    
    Some notes like this, I think it is not necessary. We can discuss.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message