carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1038: [CARBONDATA-1179] Improve the Size calculatio...
Date Wed, 28 Jun 2017 17:11:50 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1038#discussion_r124599881
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/CarbonLRUCache.java ---
    @@ -199,6 +199,36 @@ public boolean put(String columnIdentifier, Cacheable cacheInfo,
long requiredSi
       }
     
       /**
    +   * This method will check if required size is available in the memory
    +   * @param columnIdentifier
    +   * @param cacheInfo
    +   * @param requiredSize
    +   * @return
    +   */
    +  public boolean tryPut(String columnIdentifier, long requiredSize) {
    +    if (LOGGER.isDebugEnabled()) {
    --- End diff --
    
    It can better remove entry so that temp block memory also with in LRU limit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message