carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Date Tue, 27 Jun 2017 08:47:31 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124214779
  
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -640,7 +640,16 @@ object CarbonDataRDDFactory {
               val nodes = DistributionUtil.ensureExecutorsByNumberAndGetNodeList(nodeNumOfData,
                 sqlContext.sparkContext)
               val newRdd = new DataLoadCoalescedRDD[Row](rdd, nodes.toArray.distinct)
    -
    +          breakable{
    +            if (!FileUtils
    +              .validateTableExists(carbonTable.getAbsoluteTableIdentifier.getStorePath
+
    +                                   CarbonCommonConstants.FILE_SEPARATOR +
    +                                   "MetaData" + CarbonCommonConstants.FILE_SEPARATOR
+
    +                                   carbonTable.getCarbonTableIdentifier.getTableId))
{
    +              LOGGER.error(s"Table does not exists: ${carbonTable.getTableUniqueName}")
    +              break()
    +            }
    +          }
    --- End diff --
    
    This check should be done only at the final commit point of an operation. Like for data
load this should be done just before writing the table status file and after global dictionary
generation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message