carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Date Tue, 27 Jun 2017 08:40:51 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124213355
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -1099,15 +1099,18 @@ object CarbonDataRDDFactory {
             result: Option[DictionaryServer], writeAll: Boolean) = {
         // write dictionary file and shutdown dictionary server
         val uniqueTableName: String = s"${ carbonLoadModel.getDatabaseName }_${
    -      carbonLoadModel.getTableName }"
    +      carbonLoadModel.getTableName}"
    +    val tableId = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getCarbonTableIdentifier
    +      .getTableId
         result match {
           case Some(server) =>
             try {
               if (writeAll) {
    -            server.writeDictionary()
    +            server.writeDictionary(carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable)
               }
               else {
    -            server.writeTableDictionary(uniqueTableName)
    +//            server.writeTableDictionary(carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable)
    --- End diff --
    
    delete commented line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message