carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Date Tue, 27 Jun 2017 08:38:21 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124212817
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
---
    @@ -442,7 +456,15 @@ class CarbonGlobalDictionaryGenerateRDD(
                   model.hdfsLocation,
                   dictionaryForDistinctValueLookUp,
                   distinctValues)
    -            sortIndexWriteTask.execute()
    +            breakable {
    +              if (!FileUtils
    +                .validateTableExists(model.dictfolderPath + CarbonCommonConstants.FILE_SEPARATOR
+
    +                                     model.table.getTableId)) {
    +                LOGGER.error(s"Table does not exists: ${ model.table.getTableUniqueName
}")
    +                break()
    +              }
    +              sortIndexWriteTask.execute()
    +            }
    --- End diff --
    
    Remove file exist check from the executor code as it is a costly operation to check for
file existence through RPC call to namenode for each column multiple times. Instead add this
check in driver after global dictionary generation and delete the dictionary files created
in case the table has been deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message