carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1097: [WIP] [CARBONDATA-1229] Skip dictionary and d...
Date Tue, 27 Jun 2017 07:18:41 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1097#discussion_r124194537
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
    @@ -146,21 +147,31 @@ public void shutdown() throws Exception {
        * Write dictionary to the store.
        * @throws Exception
        */
    -  public void writeDictionary() throws Exception {
    +  public void writeDictionary(CarbonTable carbonTable) throws Exception {
         DictionaryMessage key = new DictionaryMessage();
         key.setType(DictionaryMessageType.WRITE_DICTIONARY);
    -    dictionaryServerHandler.processMessage(key);
    +    dictionaryServerHandler.processMessage(key, carbonTable);
    +  }
    +
    +  public void initializeDictionaryGenerator(CarbonTable carbonTable) throws Exception
{
    +    DictionaryMessage key = new DictionaryMessage();
    +    key.setType(DictionaryMessageType.TABLE_INTIALIZATION);
    +    key.setColumnName("dummy");
    +    key.setTableUniqueId(carbonTable.getCarbonTableIdentifier().getTableId());
    +    key.setTableUniqueName(carbonTable.getTableUniqueName());
    +    dictionaryServerHandler.processMessage(key, carbonTable);
       }
     
       /**
        *  Write Dictionary for one table.
        * @throws Exception
        */
     
    -  public void writeTableDictionary(String uniqueTableName) throws Exception {
    +  public void writeTableDictionary(CarbonTable carbonTable) throws Exception {
         DictionaryMessage key = new DictionaryMessage();
    -    key.setTableUniqueName(uniqueTableName);
    +    key.setTableUniqueName(carbonTable.getTableUniqueName());
    --- End diff --
    
    same comment as above...check if we can remove tableUniqueName


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message