carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1021: [CARBONDATA-1158] Hive integration code optim...
Date Tue, 20 Jun 2017 10:11:27 GMT
Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1021#discussion_r122934641
  
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonObjectInspector.java
---
    @@ -34,18 +33,16 @@
     import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
     import org.apache.hadoop.io.ArrayWritable;
     
    -public class CarbonObjectInspector extends SettableStructObjectInspector {
    +class CarbonObjectInspector extends SettableStructObjectInspector {
       private final TypeInfo typeInfo;
    -  private final List<TypeInfo> fieldInfos;
    -  private final List<String> fieldNames;
       private final List<StructField> fields;
       private final HashMap<String, StructFieldImpl> fieldsByName;
     
       public CarbonObjectInspector(final StructTypeInfo rowTypeInfo) {
    --- End diff --
    
    @chenliang613 can remove public access specifier


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message