carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anubhav100 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1021: [CARBONDATA-1158] Hive integration code optim...
Date Tue, 20 Jun 2017 10:08:46 GMT
Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1021#discussion_r122934090
  
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
---
    @@ -29,31 +30,27 @@
      * The CarbonHiveArrayInspector will inspect an ArrayWritable, considering it as an Hive
array.
      * It can also inspect a List if Hive decides to inspect the result of an inspection.
      */
    -public class CarbonArrayInspector implements SettableListObjectInspector {
    +class CarbonArrayInspector implements SettableListObjectInspector {
     
    -  private ObjectInspector arrayElementInspector;
    +  private final ObjectInspector arrayElementInspector;
     
       public CarbonArrayInspector(final ObjectInspector arrayElementInspector) {
    --- End diff --
    
    can remove public access specifier


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message