carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1053: [CARBONDATA-1188] fixed codec for UpscaleFloa...
Date Tue, 20 Jun 2017 00:19:29 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1053#discussion_r122855602
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
    @@ -96,8 +96,7 @@ public void update(Object value) {
           case DOUBLE:
             max = ((double) max > (double) value) ? max : value;
             min = ((double) min < (double) value) ? min : value;
    -        int num = getDecimalCount((double) value);
    -        decimal = decimal > num ? decimal : num;
    +        decimal = getDecimalCount((double) value);
    --- End diff --
    
    This seems not correct, it should be updated only if decimal place of this value is longer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message