carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1026: [CARBONDATA-1166] Fix bug on decimal partitio...
Date Thu, 15 Jun 2017 05:32:00 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1026#discussion_r122122509
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/InFilterImpl.java
---
    @@ -48,6 +50,9 @@ public InFilterImpl(InExpression in, PartitionInfo partitionInfo) {
           Object value = PartitionUtil.getDataBasedOnDataTypeForFilter(
               literal.getLiteralExpValue().toString(),
               partitionInfo.getColumnSchemaList().get(0).getDataType());
    +      if (PartitionType.RANGE == partitionInfo.getPartitionType() && value instanceof
String) {
    --- End diff --
    
    for range partition, we need compare string value.
    hash and list no need


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message