carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Date Wed, 14 Jun 2017 10:49:10 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121914301
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeColumnPage.java
---
    @@ -0,0 +1,321 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.page;
    +
    +import java.math.BigDecimal;
    +import java.nio.ByteBuffer;
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.memory.MemoryException;
    +import org.apache.carbondata.core.memory.UnsafeMemoryManager;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.DataTypeUtil;
    +
    +// This extension uses unsafe memory to store page data
    +public class UnsafeColumnPage extends ColumnPage {
    +  private MemoryBlock memoryBlock;
    +
    +  // base address of memoryBlock
    +  private Object baseAddress;
    +
    +  // base offset of memoryBlock
    +  private long baseOffset;
    +
    +  private static final int byteBits = DataType.BYTE.getSizeBits();
    +  private static final int shortBits = DataType.SHORT.getSizeBits();
    +  private static final int intBits = DataType.INT.getSizeBits();
    +  private static final int longBits = DataType.LONG.getSizeBits();
    +  private static final int floatBits = DataType.FLOAT.getSizeBits();
    +  private static final int doubleBits = DataType.DOUBLE.getSizeBits();
    +
    +  UnsafeColumnPage(DataType dataType, int pageSize) throws MemoryException {
    +    super(dataType, pageSize);
    +    switch (dataType) {
    +      case BYTE:
    +      case SHORT:
    +      case INT:
    +      case LONG:
    +      case FLOAT:
    +      case DOUBLE:
    +        int size = pageSize << dataType.getSizeBits();
    +        memoryBlock = UnsafeMemoryManager.allocateMemoryWithRetry(size);
    +        baseAddress = memoryBlock.getBaseObject();
    +        baseOffset = memoryBlock.getBaseOffset();
    +        break;
    +      case DECIMAL:
    +      case STRING:
    +        byteArrayData = new byte[pageSize][];
    --- End diff --
    
    Why this is not moved to offheap?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message