carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #961: [CARBONDATA-1098] change PageStatistics to use...
Date Wed, 14 Jun 2017 09:32:56 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/961#discussion_r121898445
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
    @@ -195,15 +192,36 @@ private int getDecimalCount(double value) {
       }
     
       public Object getMin() {
    -    return min;
    +    switch (dataType) {
    +      case BYTE:
    +      case SHORT:
    +      case INT:
    +      case LONG:
    +        return minLong;
    +      case FLOAT:
    +      case DOUBLE:
    +        return minDouble;
    +      case DECIMAL:
    +        return minDecimal;
    +      default:
    +        return null;
    +    }
       }
     
       public Object getMax() {
    -    return max;
    -  }
    -
    -  public Object nonExistValue() {
    -    return nonExistValue;
    +    switch (dataType) {
    +      case SHORT:
    --- End diff --
    
    please use the same datatype set in all switch case statements of this class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message