carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #995: [CARBONDATA-1123] Rename interface and variabl...
Date Wed, 14 Jun 2017 08:34:45 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/995#discussion_r121880914
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForInt.java
---
    @@ -27,25 +27,26 @@
     public class BlockIndexerStorageForInt implements IndexStorage<int[]> {
       private boolean alreadySorted;
     
    -  private int[] dataAfterComp;
    +  private int[] rowIdPage;
     
    -  private int[] indexMap;
    +  private int[] rowIdRlePage;
     
    -  private byte[][] keyBlock;
    +  private byte[][] dataPage;
     
    -  private int[] dataIndexMap;
    +  private int[] dataRlePage;
     
       private int totalSize;
     
    -  public BlockIndexerStorageForInt(byte[][] keyBlock, boolean compressData, boolean isNoDictionary,
    +  public BlockIndexerStorageForInt(byte[][] dataPage, boolean rleOnData, boolean isNoDictionary,
           boolean isSortRequired) {
    -    ColumnWithIntIndex[] columnWithIndexs = createColumnWithIndexArray(keyBlock, isNoDictionary);
    +    ColumnWithIntIndex[] dataWithRowId = createColumnWithIndexArray(dataPage, isNoDictionary);
         if (isSortRequired) {
    -      Arrays.sort(columnWithIndexs);
    +      Arrays.sort(dataWithRowId);
         }
    -    compressMyOwnWay(extractDataAndReturnIndexes(columnWithIndexs, keyBlock));
    -    if (compressData) {
    -      compressDataMyOwnWay(columnWithIndexs);
    +    int[] rowIds = extractDataAndReturnIndexes(dataWithRowId, dataPage);
    --- End diff --
    
    suggest to change:
    extractDataAndReturnIndexes => extractDataAndReturnRowIds


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message