carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From watermen <...@git.apache.org>
Subject [GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Date Wed, 14 Jun 2017 07:51:25 GMT
Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121876896
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -323,15 +340,8 @@ public double getDouble(int rowId) {
         return doubleData[rowId];
       }
     
    -  /**
    -   * Get decimal value at rowId
    -   */
    -  public byte[] getDecimalBytes(int rowId) {
    -    return byteArrayData[rowId];
    -  }
    -
       public BigDecimal getDecimal(int rowId) {
    --- End diff --
    
    Add annotation like getDouble


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message