carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From watermen <...@git.apache.org>
Subject [GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Date Wed, 14 Jun 2017 07:39:50 GMT
Github user watermen commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121874665
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -98,56 +117,54 @@ public static ColumnPage newPage(DataType dataType, int pageSize)
{
           default:
             throw new RuntimeException("Unsupported data dataType: " + dataType);
         }
    -    instance.stats = new ColumnPageStatsVO(dataType);
    -    instance.nullBitSet = new BitSet(pageSize);
         return instance;
       }
     
       protected static ColumnPage newBytePage(byte[] byteData) {
         ColumnPage columnPage = new ColumnPage(BYTE, byteData.length);
    --- End diff --
    
    If don't support, we'd better to add some notes to explain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message