carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenerlu <...@git.apache.org>
Subject [GitHub] carbondata pull request #1000: [CARBONDATA-1018] Add unsafe ColumnPage imple...
Date Wed, 14 Jun 2017 03:40:59 GMT
Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1000#discussion_r121847432
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -508,7 +567,7 @@ public static ColumnPage decompress(Compressor compressor, DataType
dataType,
       }
     
       // input byte[] is LV encoded, this function can expand it into byte[][]
    -  private static byte[][] deflatten(byte[] input) {
    +  protected static byte[][] deflatten(byte[] input) {
    --- End diff --
    
    Will it be better to move deflatten to ByteUtil which is same with flatten ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message