carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #987: [CARBONDATA-1017] Add EncodingStrategy and use...
Date Tue, 13 Jun 2017 09:20:46 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/987#discussion_r121625468
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -22,22 +22,38 @@
     import java.util.BitSet;
     
     import org.apache.carbondata.core.constants.CarbonCommonConstants;
    -import org.apache.carbondata.core.datastore.page.statistics.ColumnPageStatistics;
    +import org.apache.carbondata.core.constants.CarbonV3DataFormatConstants;
    +import org.apache.carbondata.core.datastore.compression.Compressor;
    +import org.apache.carbondata.core.datastore.page.statistics.ColumnPageStatsVO;
     import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.util.ByteUtil;
    +import org.apache.carbondata.core.util.CarbonProperties;
     import org.apache.carbondata.core.util.DataTypeUtil;
     
    -// Represent a columnar data in one page for one column.
    +import static org.apache.carbondata.core.metadata.datatype.DataType.BYTE;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.DECIMAL;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.DOUBLE;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.FLOAT;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.INT;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.LONG;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.SHORT;
    +import static org.apache.carbondata.core.metadata.datatype.DataType.STRING;
    +
    +/**
    + * Represent a columnar data in one page for one column.
    + */
     public class ColumnPage {
     
    -  protected final DataType dataType;
    -  protected final int pageSize;
    -  protected ColumnPageStatistics stats;
    +  private final int pageSize;
    +  private DataType dataType;
    +  private ColumnPageStatsVO stats;
    --- End diff --
    
    We better design this feature before changing it to interface. I think both write and
read need to change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message