carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #987: [CARBONDATA-1017] Add EncodingStrategy and use...
Date Tue, 13 Jun 2017 08:08:19 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/987#discussion_r121608594
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java
---
    @@ -22,22 +22,38 @@
     import java.util.BitSet;
     
     import org.apache.carbondata.core.constants.CarbonCommonConstants;
    -import org.apache.carbondata.core.datastore.page.statistics.ColumnPageStatistics;
    --- End diff --
    
    Yes, you are right. To make this PR smaller, I suggest to do it in another PR (EncodingStrategy
for dimension)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message