carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #987: [CARBONDATA-1017] Add EncodingStrategy and use...
Date Tue, 13 Jun 2017 04:38:00 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/987#discussion_r121580802
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageCodec.java
---
    @@ -21,15 +21,28 @@
     
     /**
      *  Codec for a column page data, implementation should not keep state across pages,
    - *  caller will use the same object to encode multiple pages.
    + *  caller may use the same object to apply multiple pages.
      */
    -public interface ColumnCodec {
    +public interface ColumnPageCodec {
    --- End diff --
    
    We better bring RLE of mdk also to similar interfaces, may we can work on future PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message