carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1013: [CARBONDATA-1154] IUD Performance Changes
Date Mon, 12 Jun 2017 18:09:35 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1013#discussion_r121485733
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/SegmentTaskIndexStore.java
---
    @@ -184,22 +184,29 @@ private SegmentTaskIndexWrapper loadAndGetTaskIdToSegmentsMap(
         SegmentUpdateStatusManager updateStatusManager =
             new SegmentUpdateStatusManager(absoluteTableIdentifier);
         String segmentId = null;
    +    UpdateVO updateVO = null;
         TaskBucketHolder taskBucketHolder = null;
         try {
           while (iteratorOverSegmentBlocksInfos.hasNext()) {
    +        // Initialize the UpdateVO to Null for each segment.
    +        updateVO = null;
    --- End diff --
    
    Better move the line `UpdateVO updateVO = null;` to here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message