carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <...@git.apache.org>
Subject [GitHub] carbondata pull request #1002: [CARBONDATA-1136] Fix compaction bug for the ...
Date Fri, 09 Jun 2017 02:09:29 GMT
Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1002#discussion_r121036463
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
    @@ -405,11 +411,16 @@ class CarbonMergerRDD[K, V](
               NodeInfo(splitsPerNode.getTaskId, splitsPerNode.getCarbonInputSplitList.size()))
     
             if (blockletCount != 0) {
    +          val taskInfo = splitInfo.asInstanceOf[CarbonInputSplitTaskInfo]
               val multiBlockSplit = new CarbonMultiBlockSplit(absoluteTableIdentifier,
    -            splitInfo.asInstanceOf[CarbonInputSplitTaskInfo].getCarbonInputSplitList,
    +            taskInfo.getCarbonInputSplitList,
                 Array(nodeName))
    -          result.add(new CarbonSparkPartition(id, partitionNo, multiBlockSplit))
    -          partitionNo += 1
    +          if (isPartitionTable) {
    --- End diff --
    
    @gvramana right, each node will get more than one taskno/partitionNo to handle. But one
spark task just handle one partitionNo/taskNo. a CarbonInputSplitTaskInfo represent a taskNo.
So different taskNo will go to different spark task.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message