carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...
Date Fri, 02 Jun 2017 15:32:44 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/971#discussion_r119886349
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatistics.java
---
    @@ -33,30 +34,30 @@
        * the unique value is the non-exist value in the row,
        * and will be used as storage key for null values of measures
        */
    -  private Object uniqueValue;
    +  private Object nonExistValue;
    --- End diff --
    
    But it will be written into file by `CarbonMetadataUtil.serializeEncodeMetaUsingByteBuffer`,
you mean read path is not using it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message