carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <>
Subject [GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...
Date Fri, 02 Jun 2017 15:29:39 GMT
Github user jackylk commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/
    @@ -74,4 +75,70 @@ public void putComplexData(int rowId, int depth, List<byte[]>
value) {
       public int getDepth() {
         return depth;
    +  @Override
    +  public void putInt(int rowId, int value) {
    --- End diff --
    How about add default implementation in ColumnPage and override the one that is needed
in ComplexColumnPage

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message