carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...
Date Fri, 02 Jun 2017 15:27:23 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/971#discussion_r119885006
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
    @@ -65,20 +68,20 @@
         this.pageSize = pageSize;
         keyColumnPage = new KeyColumnPage(pageSize,
             model.getSegmentProperties().getDimensionPartitions().length);
    -    noDictDimensionPage = new VarLengthColumnPage[model.getNoDictionaryCount()];
    +    noDictDimensionPage = new PrimitiveColumnPage[model.getNoDictionaryCount()];
         for (int i = 0; i < noDictDimensionPage.length; i++) {
    -      noDictDimensionPage[i] = new VarLengthColumnPage(pageSize);
    +      noDictDimensionPage[i] = new PrimitiveColumnPage(DataType.STRING, pageSize);
    --- End diff --
    
    If create another class for string and decimal, then it will be more complex for measure
handling. And actually in future I think all simple column handling should be similar, so
better to keep them in one class. I think a better class name can solve your comment? How
about SimpleColumnPage and ComplexColumnPage?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message