carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #971: [CARBONDATA-1015] Extract interface in data lo...
Date Fri, 02 Jun 2017 05:15:46 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/971#discussion_r119782797
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/measure/v3/CompressedMeasureChunkFileBasedReaderV3.java
---
    @@ -220,13 +223,25 @@ public CompressedMeasureChunkFileBasedReaderV3(BlockletInfo blockletInfo,
String
           valueEncodeMeta.add(CarbonUtil
               .deserializeEncoderMetaNew(measureColumnChunk.getEncoder_meta().get(i).array()));
         }
    -    WriterCompressModel compressionModel = CarbonUtil.getValueCompressionModel(valueEncodeMeta);
    -    ValueCompressionHolder values = compressionModel.getValueCompressionHolder()[0];
    +
    +    MeasurePageStatistics stats = CarbonUtil.getMeasurePageStats(valueEncodeMeta);
    --- End diff --
    
    it seems this code is repeated in all readers, so better move abstract class or utility


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message