carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #964: [CARBONDATA-1099] Fixed bug for carbon-spark-s...
Date Fri, 02 Jun 2017 00:48:58 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/964#discussion_r119761693
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
---
    @@ -43,7 +43,7 @@
        * Attribute for Carbon LOGGER
        */
       private static final LogService LOGGER =
    -      LogServiceFactory.getLogService(ForwardDictionaryCache.class.getName());
    +      LogServiceFactory.getLogService(ReverseDictionaryCache.class.getName());
    --- End diff --
    
    yeah, there is no need to fix this in the current issue. I just found it when I submitted
the code...
    
    so, should I rollback this change and start a new issue, OR just add another comment in
this issue about this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message