carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #958: [CARBONDATA-1088] Added interfaces for Data Ma...
Date Thu, 01 Jun 2017 04:55:20 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/958#discussion_r119527699
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/TableBlockInfo.java
---
    @@ -307,4 +316,45 @@ public void setVersion(ColumnarFormatVersion version) {
       public void setBlockStorageIdMap(Map<String, String> blockStorageIdMap) {
         this.blockStorageIdMap = blockStorageIdMap;
       }
    +
    +  public byte[] getSerializedData() throws IOException {
    --- End diff --
    
    If we implement serializable we cannot control what to write and what not to write, here
we have complete control of how to write the data.  I will create the new interface CarbonWritable
like hadoop's Writable and add these methods to there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message