carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #981: [CARBONDATA-1111]Improve No dictionary column ...
Date Thu, 01 Jun 2017 04:40:35 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/981#discussion_r119526605
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
    @@ -35,14 +33,19 @@
       protected DimColumnResolvedFilterInfo dimColEvaluatorInfo;
       protected DimColumnExecuterFilterInfo dimColumnExecuterInfo;
       protected SegmentProperties segmentProperties;
    -
    +  /**
    +   * is dimension column data is natural sorted
    +   */
    +  private boolean isNatualSorted;
    --- End diff --
    
    Please correct the variable name....isNaturalSorted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message