carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #986: [CARBONDATA-1108] Supported IUD for vector rea...
Date Thu, 01 Jun 2017 04:13:07 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/986#discussion_r119524856
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java
---
    @@ -144,6 +144,8 @@ protected void prepareDimensionAndMeasureColumnVectors() {
             return;
           }
           fillColumnVectorDetails(columnarBatch, rowCounter, requiredRows);
    +      scannedResult
    +          .markFilteredRows(columnarBatch, rowCounter, requiredRows, columnarBatch.getRowCounter());
    --- End diff --
    
    please break the line after `(`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message