Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: gvramana <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-972-carbondata@git.apache.org>
In-Reply-To: <git-pr-972-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #972: [WIP] Added set command in carbon to update pr...
Content-Type: text/plain
Message-Id: <20170531151634.CF5CDE109B@git1-us-west.apache.org>
Date: Wed, 31 May 2017 15:16:34 +0000 (UTC)
archived-at: Wed, 31 May 2017 15:16:37 -0000

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/972#discussion_r119370103
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/SessionParams.java ---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.util;
    +
    +import java.io.Serializable;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.carbondata.common.logging.LogService;
    +import org.apache.carbondata.common.logging.LogServiceFactory;
    +import org.apache.carbondata.core.cache.CacheProvider;
    +import org.apache.carbondata.core.exception.InvalidConfigurationException;
    +import static org.apache.carbondata.core.constants.CarbonCommonConstants.*;
    +
    +import org.apache.commons.lang.StringUtils;
    +
    +
    +/**
    + * This class maintains carbon session params
    + */
    +public class SessionParams implements Serializable {
    +
    +  private static final LogService LOGGER =
    +      LogServiceFactory.getLogService(CacheProvider.class.getName());
    +
    +  private Map<String, String> sProps;
    +
    +  public SessionParams() {
    +    sProps = new HashMap<>();
    +  }
    +
    +  /**
    +   * This method will be used to get the properties value
    +   *
    +   * @param key
    +   * @return properties value
    +   */
    +  public String getProperty(String key) {
    +    return sProps.get(key);
    +  }
    +
    +  /**
    +   * This method will be used to add a new property
    +   *
    +   * @param key
    +   * @return properties value
    +   */
    +  public SessionParams addProperty(String key, String value) throws InvalidConfigurationException {
    +    boolean isValidConf = validateKeyValue(key, value);
    +    if (isValidConf) {
    +      LOGGER.audit("The key " + key + " with value " + value + " added in the session param");
    +      sProps.put(key, value);
    +    }
    +    return this;
    +  }
    +
    +  private boolean validateKeyValue(String key, String value) throws InvalidConfigurationException {
    --- End diff --
    
    Here also case sensitive problem will come


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---