Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-945-carbondata@git.apache.org>
In-Reply-To: <git-pr-945-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #945: [CARBONDATA-1088] Minimize the driver side blo...
Content-Type: text/plain
Message-Id: <20170530141614.68443DFC8B@git1-us-west.apache.org>
Date: Tue, 30 May 2017 14:16:14 +0000 (UTC)
archived-at: Tue, 30 May 2017 14:16:16 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/945#discussion_r119111383
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/array/BlockArrayIndexBuilder.java ---
    @@ -0,0 +1,189 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.datastore.impl.array;
    +
    +import java.io.IOException;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.datastore.BTreeBuilderInfo;
    +import org.apache.carbondata.core.datastore.BtreeBuilder;
    +import org.apache.carbondata.core.datastore.DataRefNode;
    +import org.apache.carbondata.core.datastore.block.BlockInfo;
    +import org.apache.carbondata.core.memory.CarbonUnsafe;
    +import org.apache.carbondata.core.memory.MemoryAllocator;
    +import org.apache.carbondata.core.memory.MemoryAllocatorFactory;
    +import org.apache.carbondata.core.memory.MemoryBlock;
    +import org.apache.carbondata.core.metadata.blocklet.DataFileFooter;
    +import org.apache.carbondata.core.metadata.blocklet.index.BlockletMinMaxIndex;
    +
    +/**
    + * Builder for storing block index in unsafe array format
    + */
    +public class BlockArrayIndexBuilder implements BtreeBuilder {
    --- End diff --
    
    We should use interface defined by #958 
    Suggest to merge #958 first then rebase on it, ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---