Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: kumarvishal09 <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-909-carbondata@git.apache.org>
In-Reply-To: <git-pr-909-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Content-Type: text/plain
Message-Id: <20170530141422.D871EDFC8B@git1-us-west.apache.org>
Date: Tue, 30 May 2017 14:14:22 +0000 (UTC)
archived-at: Tue, 30 May 2017 14:14:24 -0000

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r118451182
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java ---
    @@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
         return aggType;
       }
     
    +  /**
    +   * the method prepares and return the message mentioning the reason of badrecord
    +   *
    +   * @param columnName
    +   * @param dataType
    +   * @return
    +   */
    +  public static String prepareFailureReason(String columnName, DataType dataType) {
    --- End diff --
    
    Once data loading is done or step which is handling bad record is finished map will be discarded so it is ok(Only when bad record is enabled). My intention for this comment was to create this message only once, don't create this for each bad record. Or you can do lazy creation, when you found first bad record then create the message, from next time use the same message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---