Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-930-carbondata@git.apache.org>
In-Reply-To: <git-pr-930-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #930: [CARBONDATA-1073] Support INPUT_FILES
Content-Type: text/plain
Message-Id: <20170524014603.C12F9DFF9F@git1-us-west.apache.org>
Date: Wed, 24 May 2017 01:46:03 +0000 (UTC)
archived-at: Wed, 24 May 2017 01:46:05 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/930#discussion_r118145651
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -542,7 +554,7 @@ private boolean isValidBlockBasedOnUpdateDetails(
                   updateStatusManager.getInvalidTimestampRange(segmentId), updateStatusManager,
                   segmentId, validTaskKeys);
           if (!tableBlockInfoList.isEmpty()) {
    -        // getFileStatusOfSegments(job, new int[]{ segmentId }, fileStatusList);
    +        // getFileStatus(job, new String[]{ segmentId }, new String[] { fileName }, fileStatusList);
    --- End diff --
    
    if it is not used, remove it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---