Return-Path: <issues-return-9527-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id EF14F200C63
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 11 May 2017 16:31:11 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id EDD63160BCA; Thu, 11 May 2017 14:31:11 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 46B21160BB2
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 11 May 2017 16:31:11 +0200 (CEST)
Received: (qmail 30452 invoked by uid 500); 11 May 2017 14:31:10 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 30421 invoked by uid 99); 11 May 2017 14:31:09 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 14:31:09 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A7618DFFB3; Thu, 11 May 2017 14:31:09 +0000 (UTC)
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-842-carbondata@git.apache.org>
In-Reply-To: <git-pr-842-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #842: [CARBONDATA-937] Data loading for partition ta...
Content-Type: text/plain
Message-Id: <20170511143109.A7618DFFB3@git1-us-west.apache.org>
Date: Thu, 11 May 2017 14:31:09 +0000 (UTC)
archived-at: Thu, 11 May 2017 14:31:12 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/842#discussion_r116005424
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/partition/RangePartitioner.java ---
    @@ -0,0 +1,132 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.scan.partition;
    +
    +import java.io.Serializable;
    +import java.math.BigDecimal;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.metadata.schema.PartitionInfo;
    +import org.apache.carbondata.core.util.ByteUtil;
    +
    +/**
    + * Range Partitioner
    + */
    +public class RangePartitioner implements Partitioner {
    +
    +  private int partitions;
    +  private Object[] bounds;
    +  private Comparator comparator;
    +
    +  public RangePartitioner(PartitionInfo partitionInfo) {
    +    List<String> values = partitionInfo.getRangeInfo();
    +    DataType partitionColumnDataType = partitionInfo.getColumnSchemaList().get(0).getDataType();
    +    partitions = values.size();
    +    bounds = new Object[partitions];
    +    if (partitionColumnDataType == DataType.STRING) {
    +      for (int i = 0; i < partitions; i++) {
    +        bounds[i] = ByteUtil.toBytes(values.get(i));
    +      }
    +    } else {
    +      for (int i = 0; i < partitions; i++) {
    +        bounds[i] = PartitionUtil.getDataBasedOnDataType(values.get(i), partitionColumnDataType);
    +      }
    +    }
    +
    +    switch (partitionColumnDataType) {
    +      case INT:
    +        comparator = new IntComparator();
    +        break;
    +      case SHORT:
    +        comparator = new ShortComparator();
    +        break;
    +      case DOUBLE:
    +        comparator = new DoubleComparator();
    +        break;
    +      case LONG:
    +      case DATE:
    +      case TIMESTAMP:
    +        comparator = new LongComparator();
    +        break;
    +      case DECIMAL:
    +        comparator = new BigDecimalComparator();
    +        break;
    +      default:
    +        comparator = new ByteArrayComparator();
    +    }
    +  }
    +
    +  @Override public int numPartitions() {
    +    return partitions + 1;
    +  }
    +
    +  @Override public int getPartition(Object key) {
    +    if (key == null) {
    +      return partitions;
    +    } else {
    +      for (int i = 0; i < partitions; i++) {
    +        if (comparator.compareTo(key, bounds[i])) {
    +          return i;
    +        }
    +      }
    +      return partitions;
    +    }
    +  }
    +
    +  interface Comparator extends Serializable {
    --- End diff --
    
    Do you want a serialization Comparator? Name it `SerializableComparator`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---