Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-896-carbondata@git.apache.org>
In-Reply-To: <git-pr-896-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #896: [CARBONDATA-936] Create table with partition a...
Content-Type: text/plain
Message-Id: <20170511015539.E1400DFE61@git1-us-west.apache.org>
Date: Thu, 11 May 2017 01:55:39 +0000 (UTC)
archived-at: Thu, 11 May 2017 01:55:42 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/896#discussion_r115891532
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -506,6 +506,14 @@ class TableNewProcessor(cm: TableModel) {
           tableSchema.setBucketingInfo(
             new BucketingInfo(bucketCols.asJava, cm.bucketFields.get.numberOfBuckets))
         }
    +    if (cm.partitionInfo.isDefined) {
    +      val partitionInfo = cm.partitionInfo.get
    +      val partitionCols = partitionInfo.getColumnSchemaList.asScala.map { columnSchema =>
    +        allColumns.find(_.getColumnName.equalsIgnoreCase(columnSchema.getColumnName)).get
    --- End diff --
    
    suggest to use `filter` instead of `find`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---