carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunal642 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #894: [CARBONDATA-1038] Fixed exception in...
Date Mon, 08 May 2017 13:29:53 GMT
GitHub user kunal642 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/894

    [CARBONDATA-1038] Fixed exception in dictionary_exclude for string datatype

    Analysis: 
    1. The data type that could be added to the dictionary_exclude list was listed as "string"
instead of "stringtype" which caused the exception.
    2. If no table name is provided in the options while creating table then the default table
name of "defalut_table" is taken. Which is not the expected result.
    
    Solution: 
    1. changed the datatype from "string" to "stringtype".
    2. Throw exception instead of taking "default_table" as the table name if no name is provided.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/incubator-carbondata CARBONDATA-1038

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #894
    
----
commit c86f1cdbec68c555a2a332a5b98b992dd1b71747
Author: kunal642 <kunal.kapoor@knoldus.in>
Date:   2017-05-08T12:37:22Z

    fixed exception in dictionary_exclude for string datatype

commit 2afc153983aaf0a606967824ee9cb16c663e1f72
Author: kunal642 <kunal.kapoor@knoldus.in>
Date:   2017-05-08T13:23:36Z

    added test cases

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message