carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #970: [CARBONDATA-1104] Query failure while using un...
Date Tue, 30 May 2017 04:47:05 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/970#discussion_r119011516
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeVariableLengthDimesionDataChunkStore.java
---
    @@ -164,7 +175,26 @@ public UnsafeVariableLengthDimesionDataChunkStore(long totalSize,
boolean isInve
             .equals(CarbonCommonConstants.MEMBER_DEFAULT_VAL_ARRAY, value)) {
           vector.putNull(vectorRow);
         } else {
    -      vector.putBytes(vectorRow, value);
    +      DataType dt = vector.getType();
    --- End diff --
    
    Add switch case instead of instanceof check , please handle in other places


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message