carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <>
Subject [GitHub] carbondata pull request #932: [CARBONDATA-1074] Add TablePage and ConvertedR...
Date Sat, 27 May 2017 07:38:36 GMT
Github user ravipesala commented on a diff in the pull request:
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/row/
    @@ -0,0 +1,98 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.processing.newflow.row;
    +import org.apache.carbondata.core.datastore.block.SegmentProperties;
    +import org.apache.carbondata.core.keygenerator.KeyGenException;
    +import org.apache.carbondata.core.keygenerator.KeyGenerator;
    +import org.apache.carbondata.core.scan.wrappers.ByteArrayWrapper;
    +public class ConvertedRow {
    --- End diff --
    Why we should create new instance here for every row. Here all methods could be static.
Just pass CarbonRow to the required method and get the converted data. So even `CarbonFactDataHandlerColumnar.addDataToStore`
should only take `CarbonRow`. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message