carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #952: [CARBONDATA-1094] Wrong results returned by th...
Date Fri, 26 May 2017 10:08:58 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/952#discussion_r118672486
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
    @@ -43,6 +52,11 @@ public ExcludeFilterExecuterImpl(DimColumnResolvedFilterInfo dimColEvaluatorInfo
         this.segmentProperties = segmentProperties;
         FilterUtil.prepareKeysFromSurrogates(dimColEvaluatorInfo.getFilterValues(), segmentProperties,
             dimColEvaluatorInfo.getDimension(), dimColumnExecuterInfo);
    +    // check if inverted index exists for the filter column
    +    isInvertedIndexColumn = CarbonUtil
    +        .hasEncoding(dimColEvaluatorInfo.getDimension().getEncoder(),
    +            Encoding.INVERTED_INDEX);
    +    isSortColumn = dimColEvaluatorInfo.getDimension().getColumnSchema().isSortColumn();
    --- End diff --
    
    During data load, according to the implementation, And operator is applied between isUseInvertedIndex
and isSortColumn property. If anyone is false it will not sort the column vertically and will
not create inverted index for that column. But in master schema the boolean flag will still
be according to the values specified by the user. Therefor we need to check false as if anyone
is false inverted index will not exist for that column


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message