carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #952: [CARBONDATA-1094] Wrong results returned by th...
Date Fri, 26 May 2017 09:42:43 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/952#discussion_r118668176
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
    @@ -94,6 +94,14 @@
        * Applicable for restructure scenarios
        */
       protected boolean[] isMeasurePresentInCurrentBlock;
    +  /**
    +   * flag to check whether inverted index exists for the filter column
    +   */
    +  protected boolean isInvertedIndexColumn;
    +  /**
    +   * flag to check whether the column is included for sorting during data load
    +   */
    +  protected boolean isSortColumn;
    --- End diff --
    
    Please correct me isSortColumn property is for global sort, so filter does not care about
whether column was part of global sort or not. Only we need to check whether column data is
sorted or not so isSortColumn check and this variable is not required. Please check and handled
in all the places if not required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message