carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <>
Subject [GitHub] carbondata pull request #952: [CARBONDATA-1094] Wrong results returned by th...
Date Fri, 26 May 2017 09:42:42 GMT
Github user kumarvishal09 commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/
    @@ -242,7 +256,14 @@ public boolean isScanRequired(byte[] blockMinValue, byte[] blockMaxValue,
         //                       Block Min <-----------------------> Block Max
         //         Filter Min <-----------------------------------------------> Filter
    -    if (isDimensionPresentInCurrentBlock == true) {
    +    if (isDimensionPresentInCurrentBlock) {
    +      // if a column is unsorted, min and max for that column will not be correct and
    --- End diff --
    During data loading even if data is not sorted we are calculating the min max so not need
to add this code, in all the filter classes only if inverted index is false we need to go
iterative approach

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message