carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #932: [CARBONDATA-1074] Add TablePage and ConvertedR...
Date Thu, 25 May 2017 00:06:01 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/932#discussion_r118392660
  
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/readsupport/SparkRowReadSupportImpl.java
---
    @@ -36,7 +36,7 @@
         isMeasure = new boolean[carbonColumns.length];
         dataTypes = new DataType[carbonColumns.length];
         for (int i = 0; i < carbonColumns.length; i++) {
    -      isMeasure[i] = !carbonColumns[i].isDimesion();
    +      isMeasure[i] = !carbonColumns[i].isDimension();
    --- End diff --
    
    actually, the initialization in this class is unnecessary, because `readRow` only return
a `new GenericInternalRow(data)`, so I will move `isMeasure` variable 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message