carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #940: [CARBONDATA-1081] Use binarySearch to replace ...
Date Wed, 24 May 2017 08:40:43 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/940#discussion_r118194366
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
    @@ -146,9 +146,17 @@ private BitSet setFilterdIndexToBitSet(FixedLengthDimensionDataChunk
dimColumnDa
         BitSet bitSet = new BitSet(numerOfRows);
         bitSet.flip(0, numerOfRows);
         byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
    -    for (int k = 0; k < filterValues.length; k++) {
    +    if (filterValues.length > 1) {
    --- End diff --
    
    This code will not work when No Inverted index is configured for that column while creating
the column. In that case data wont be sorted and this code will five wrong result and whether
filter value is one or more than one this if data is sorted we can add binary search


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message