carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #916: [CARBONDATA-938] Prune partitions for filter q...
Date Fri, 19 May 2017 01:29:04 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/916#discussion_r117387947
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -255,11 +258,32 @@ private static AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration
           if (null == carbonTable) {
             throw new IOException("Missing/Corrupt schema file for table.");
           }
    +
           CarbonInputFormatUtil.processFilterExpression(filter, carbonTable);
    +
    +      // prune partitions for filter query on partition table
    +      BitSet partitionMap = null;
    --- End diff --
    
    suggest to rename all `partitionMap` to `matchedPartitions` in all functions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message