carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #916: [CARBONDATA-938] Prune partitions for filter q...
Date Fri, 19 May 2017 01:16:24 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/916#discussion_r117386887
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/partition/DefaultPartitionFilterImpl.java
---
    @@ -0,0 +1,43 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.scan.filter.partition;
    +
    +import java.util.BitSet;
    +
    +import org.apache.carbondata.core.scan.partition.PartitionUtil;
    +import org.apache.carbondata.core.scan.partition.Partitioner;
    +
    +/**
    + * the default implement of partition filter
    + */
    +public class DefaultPartitionFilterImpl implements PartitionFilterIntf {
    +
    +  /**
    +   * true: all partitions are required
    +   * false: no partition is required
    +   */
    +  private boolean isContainAll;
    +
    +  public DefaultPartitionFilterImpl(boolean isContainAll) {
    --- End diff --
    
    There is only one instance creation whose `isContainAll` is `false`
    Can you make another implementation for it? I think the name `isContainAll` is not intuitive.
    ```
          case FALSE:
            return new DefaultPartitionFilterImpl(false);
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message