carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Date Thu, 18 May 2017 10:31:31 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117211876
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
    @@ -522,4 +522,16 @@ public static String checkAndCreateCarbonStoreLocation(String factStoreLocation,
         return aggType;
       }
     
    +  /**
    +   * the method prepares and return the message mentioning the reason of badrecord
    +   *
    +   * @param columnName
    +   * @param dataType
    +   * @return
    +   */
    +  public static String prepareFailureReason(String columnName, DataType dataType) {
    --- End diff --
    
    @mohammadshahidkhan when number of bad records are more then for each record prepare this
message will be very costly as we know the data type and column name, if bad record is enabled
can we prepare this message initially and store it in some map and whenever any bad record
 will come we can get this message from map based on column name. For each bad record prepare
this message will hit data loading speed 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message