carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] carbondata pull request #909: [CARBONDATA-1049] avoid logging raw data into ...
Date Thu, 18 May 2017 10:31:31 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/909#discussion_r117213526
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -292,7 +292,7 @@ public static Object getDataBasedOnDataType(String data, DataType
actualDataType
                 Date dateToStr = dateformatter.get().parse(data);
                 return dateToStr.getTime() * 1000;
               } catch (ParseException e) {
    -            LOGGER.error("Cannot convert" + data + " to Time/Long type value" + e.getMessage());
    +            LOGGER.error("Cannot convert value to Time/Long type value" + e.getMessage());
    --- End diff --
    
    Concatenating 2 message  and logging will be better or adding two different log message
will be better without newline(first message without newline)?? Because for each concatenation
it will create new String object.
    @ravipesala @gvramana Please comment!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message