carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #918: [WIP] Support add store read size metrics for ...
Date Wed, 17 May 2017 17:53:23 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/918#discussion_r117069219
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
    @@ -232,6 +237,10 @@ class CarbonScanRDD(
               val value = reader.getCurrentValue
               value
             }
    +        private def close() {
    +          val carbonSplit = split.asInstanceOf[CarbonSparkPartition]
    +          inputMetricsStats.updateBytesRead(carbonSplit.split)
    --- End diff --
    
    It is a wrong statistic we are providing to spark, it supposed to be how much we read
from carbon file. This logic is current only if each block has only one blocklet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message