carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From QiangCai <>
Subject [GitHub] carbondata pull request #896: [CARBONDATA-936] Create table with partition a...
Date Thu, 11 May 2017 03:59:51 GMT
Github user QiangCai commented on a diff in the pull request:
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
    @@ -122,15 +122,15 @@ class CarbonSqlAstBuilder(conf: SQLConf) extends SparkSqlAstBuilder(conf)
             if (!CommonUtil.validatePartitionColumns(tableProperties, partitionerFields))
               throw new MalformedCarbonCommandException("Invalid partition definition")
    -        // partition columns must be part of the schema
    +        // partition columns can't be part of the schema
             val badPartCols =
    -        if (badPartCols.isEmpty) {
    --- End diff --
    It will add more two parameters to validate function, better to keep.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message