carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #896: [CARBONDATA-936] Create table with partition a...
Date Thu, 11 May 2017 01:58:07 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/896#discussion_r115891756
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
    @@ -122,15 +122,15 @@ class CarbonSqlAstBuilder(conf: SQLConf) extends SparkSqlAstBuilder(conf)
{
             if (!CommonUtil.validatePartitionColumns(tableProperties, partitionerFields))
{
               throw new MalformedCarbonCommandException("Invalid partition definition")
             }
    -        // partition columns must be part of the schema
    +        // partition columns can't be part of the schema
             val badPartCols = partitionerFields.map(_.partitionColumn).toSet.intersect(colNames.toSet)
    -        if (badPartCols.isEmpty) {
    --- End diff --
    
    please move all validation logic into validate function


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message